[bin-wrappers] Reduce/improve when we create bin wrappers #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Oct 3, 2023
| @@ -134,12 +125,11 @@ func CreateDevboxSymlinkIfPossible() error { | |||
| } | |||
|
|
|||
| type createWrapperArgs struct { | |||
| devboxer | |||
There was a problem hiding this comment.
yes! thank god we removed this.
| } | ||
|
|
||
| return wrapnix.CreateWrappers(ctx, d) | ||
| return d.saveCfg() |
There was a problem hiding this comment.
why don't we save the lockfile here, after the config has been changed? Similar to the end of AddPackages.
There was a problem hiding this comment.
It's actually not needed in either because ensurePackagesAreInstalled already does lockfile.Tidy
will remove from Add()
They predate the call inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes all
CreateWrapperscalls except one. It also removes the interface used to prevent a circular dependency and passed in all arguments at the callsite. It no longer needs to recompute nix env.It helps address performance issues where CreateWrappers was causing extra calls to ComputeNixEnv.
How was it tested?
It builds and runs. This will need extensive testing.