-
Notifications
You must be signed in to change notification settings - Fork 249
[runx] Proof of concept for runx integration #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, lets do this and start using internally!
Before announcing this to Devbox users:
I have a significant concern about using runx:
as the user-facing prefix in devbox.json. I think that'll confuse people: "I'm not running anything". IIRC @mohsenari was confused when you used this term in a meeting.
Finding an alternative would be good. One suggestion is binary:
. Good discussion to have with the team and/or users.
"[email protected]", | ||
"go@latest" | ||
"go@latest", | ||
"runx:golangci/golangci-lint@latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be preferable to include a source reference. In the future, runx may support github, gitlab, sourcehut, custom domain etc.
runx: github.com/golangci/golangci-lint@latest
@savil should I merge this with Another issue I need to fix before merging is the github rate limits on their |
I think we can merge, and make any follow up changes prior to a public announcement. Incremental progress ftw! |
Summary
Inspired by golangci-lint being broken in nixpkgs, I wanted to see if I could get a quick and dirty implementation so we can replace golangci-lint from nixpkgs with runx. The current PR implements this using
runx:<path>
syntax. Since we already usegithub:<path>
for nix flakes, I can't use that without breaking backwards compatibility. We could overload it.What this PR implements:
Things that are not implemented by this PR:
How was it tested?