Skip to content

[runx] Proof of concept for runx integration #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 6, 2023
Merged

[runx] Proof of concept for runx integration #1524

merged 10 commits into from
Oct 6, 2023

Conversation

mikeland73
Copy link
Contributor

Summary

Inspired by golangci-lint being broken in nixpkgs, I wanted to see if I could get a quick and dirty implementation so we can replace golangci-lint from nixpkgs with runx. The current PR implements this using runx:<path> syntax. Since we already use github:<path> for nix flakes, I can't use that without breaking backwards compatibility. We could overload it.

What this PR implements:

  • Add and rm of runx, with and without versions.
  • runx installed packages are added to PATH for run, shell, etc

Things that are not implemented by this PR:

  • Search and validation. Currently trying to install a non-existing package will fail with a semi-cryptic error.
  • lockfile support.

How was it tested?

image

@mikeland73 mikeland73 requested review from gcurtis, loreto and savil October 3, 2023 04:42
Copy link
Collaborator

@savil savil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, lets do this and start using internally!

Before announcing this to Devbox users:

I have a significant concern about using runx: as the user-facing prefix in devbox.json. I think that'll confuse people: "I'm not running anything". IIRC @mohsenari was confused when you used this term in a meeting.

Finding an alternative would be good. One suggestion is binary:. Good discussion to have with the team and/or users.

"[email protected]",
"go@latest"
"go@latest",
"runx:golangci/golangci-lint@latest"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be preferable to include a source reference. In the future, runx may support github, gitlab, sourcehut, custom domain etc.

runx: github.com/golangci/golangci-lint@latest

@mikeland73
Copy link
Contributor Author

@savil should I merge this with runx or should we decide on the name first?

Another issue I need to fix before merging is the github rate limits on their releases.json endpoint. I need to make changes to runx so that releases.json gets called with github access token.

@savil
Copy link
Collaborator

savil commented Oct 4, 2023

I think we can merge, and make any follow up changes prior to a public announcement. Incremental progress ftw!

@mikeland73 mikeland73 merged commit b2a8835 into main Oct 6, 2023
@mikeland73 mikeland73 deleted the landau/runx branch October 6, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants