[lockfile] When updating store-paths, we should update all fields #1530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we update the store-paths in the lockfile, we should also update the other fields, including "resolved" for the nixpkgs commit hash, and the modified-time.
This way the exact same derivation is used whether installing the binary directly via store-path, or via relying on the derivation in the package's "resolved" field. This ensures parity for the following scenarios:
How was it tested?
Did
devbox update
and saw thatgo@latest
had new store-paths, and the "resolved" field was also updated.