[minor cleanup] use flake dir instead of flake-file-path in nix print-dev-env #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
savil
requested review from
mikeland73,
ipince and
gcurtis
and removed request for
mikeland73 and
ipince
gcurtis
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This has been bugging me for many months. Previously, with DEVBOX_DEBUG=1 and doing
some command that evaluated
nix print-dev-env, we'd see output like:This is because
nix print-dev-envexpects the path to the flake directory but not including the flake.nix itself.How was it tested?
changed devbox.json to trigger a re-evaluation of
nix print-dev-env, and thenDEVBOX_DEBUG=1 devbox installand didn't see such output