add helpful env vars during shell + run #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
reviewed
Oct 10, 2023
internal/impl/devbox.go
Outdated
| env["DEVBOX_PROJECT_ROOT"] = d.projectDir | ||
| env["DEVBOX_CONFIG_DIR"] = d.projectDir + "/devbox.d" | ||
| env["DEVBOX_PACKAGES_DIR"] = d.projectDir + "/.devbox/virtenv/.wrappers" | ||
|
|
There was a problem hiding this comment.
A couple of concerns:
- We should insert this after the
err != nilcheck below. - We make a copy of the env on line 786 into
originalEnv. So we likely want to add it some place after that.
My suggestion is add it before line 864 configEnv, err := d.configEnvs(ctx, env) so it can be used to derive other env-vars etc. in the devbox.json config
There was a problem hiding this comment.
Good suggestion, updated!
Lagoja
force-pushed
the
jl/useful-env-vars
branch
from
7829250 to
320fea9
Compare
savil
approved these changes
Oct 10, 2023
|
One concern I have with this is that in these point to the last devbox project you shellenv'd into. It's not a deal breaker, but just a concern. |
mikeland73
approved these changes
Oct 11, 2023
I'm not sure I follow the concern, is there an issue that could cause? Since you can't have nested devbox shells, that should be ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a few helpful Env Vars to the shell/run/services environment. These should help in situations where a developer needs to refer to files within their project directory, but doesn't want to hardcode the path into their configuration
Since this just adds a few variables to the shell environment, it should be a fairly low risk change
How was it tested?
Locally