[cicd] Unify lint, add caching #1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcurtis
reviewed
Oct 10, 2023
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Would it be faster to build all platforms on a single machine and set GOOS/GOARCH?
There was a problem hiding this comment.
That would be a bit slower no? In this case they can run in parallel?
.github/workflows/cli-tests.yaml
Outdated
| - name: Upload devbox artifact | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: devbox-${{ runner.os }} |
There was a problem hiding this comment.
Could we throw in runner.arch too just in case we start using M1/M2 runners?
.github/workflows/cli-tests.yaml
Outdated
| with: | ||
| args: "--out-${NO_FUTURE}format colored-line-number --timeout=10m" | ||
| skip-cache: true | ||
| - run: go run ./cmd/devbox run lint |
There was a problem hiding this comment.
Use the built artifact here too?
There was a problem hiding this comment.
I changed this, but I think longer term we can use the released devbox instead for speed since this is one of the first tests we want to see complete.
.github/workflows/cli-tests.yaml
Outdated
| - name: Build devbox | ||
| run: go install ./cmd/devbox | ||
| name: devbox-${{ runner.os }} | ||
| - run: chmod +x ./devbox |
There was a problem hiding this comment.
I think it also needs to be added to the PATH.
|
Comments addressed. @gcurtis PTAL |
gcurtis
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How was it tested?
CICD