devpkg: make FlakeInstallable.Outputs a string #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Nov 1, 2023
Change `ParseInstallable.Outputs` from a `[]string` to a `string` and move the splitting logic to a `SplitOutputs` method. This makes installables directly comparable with `==` and usable as map keys, which is something we currently do a bunch using unparsed installable strings.
gcurtis
force-pushed
the
gcurtis/installable-outputs
branch
from
a72df3e to
2075d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ParseInstallable.Outputsfrom a[]stringto astringand move the splitting logic to aSplitOutputsmethod. This makes installables directly comparable with==and usable as map keys, which is something we currently do a bunch using unparsed installable strings.