[glibc] Add patch-glibc patch and fix when package in binary cache #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Dec 6, 2023
| pkgs.ast.setPackageBool(name, "patch_glibc", v) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
just to confirm, if the packages is a []string in json, then this will convert it to a map[string] (string | object)?
wait, we should only be generating the flake on linux (since this issue affects linux, and not macos) |
savil
reviewed
Dec 6, 2023
| @@ -25,6 +25,10 @@ const BinaryCache = "https://cache.nixos.org" | |||
| // ALERT: Callers in a perf-sensitive code path should call FillNarInfoCache | |||
| // before calling this function. | |||
| func (p *Package) IsInBinaryCache() (bool, error) { | |||
| // Patched glibc packages are not in the binary cache. | |||
| if p.PatchGlibc { | |||
There was a problem hiding this comment.
this should be PatchGlibc && linux
or better still the PatchGlibc boolean should only be set if it is specified in the devbox.json and the current OS is linux
Only the linux version is patched but the flake still gets created. I'll fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--patch-glibcflagHow was it tested?
devbox add python --patch-glibc