[plugins] Ensure plugin flakes get upgraded on every install #1687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
force-pushed
the
landau/fix-plugins
branch
from
6caa4ae to
3854ae5
Compare
savil
approved these changes
Dec 20, 2023
internal/impl/packages.go
Outdated
| @@ -390,6 +392,10 @@ func (d *Devbox) syncPackagesToProfile(ctx context.Context, mode installMode) er | |||
| return err | |||
| } | |||
| pending = append(pending, pkg) | |||
| } else if f, _ := pkg.FlakeInstallable(); d.pluginManager.PathIsInVirtenv(f.Ref.Path) { | |||
There was a problem hiding this comment.
lets not ignore the error here? f, _ := pkg.FlakeInstallable();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run
nix profile upgradeon any virtenv (plugin) flakes after any package is installed. This is a bit blunt, but works. (ideally we determine which plugin is being touched and we only upgrade that flake, but that's a bit tricky)Fixes #1680
How was it tested?
devbox add php devbox add php82Extensions.xdebug devbox run php -m | grep xdebug