Skip to content

[secrets] Show better error if secrets not initialized #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[secrets] Show better error if secrets not initialized #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions internal/devbox/devbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,20 +1108,27 @@ func (d *Devbox) configEnvs(
env := map[string]string{}
if d.cfg.IsEnvsecEnabled() {
secrets, err := d.Secrets(ctx)
if err != nil {
// TODO: replace this with error.Is check once envsec exports it.
if err != nil && !strings.Contains(err.Error(), "project not initialized") {
return nil, err
}

cloudSecrets, err := secrets.List(ctx)
if err != nil {
} else if err != nil {
ux.Fwarning(
os.Stderr,
"Error reading secrets from jetpack cloud: %s\n\n",
err,
d.stderr,
"Ignoring env_from directive. jetpack cloud secrets is not "+
"initialized. Run `devbox secrets init` to initialize it.\n",
)
} else {
for _, secret := range cloudSecrets {
env[secret.Name] = secret.Value
cloudSecrets, err := secrets.List(ctx)
if err != nil {
ux.Fwarning(
os.Stderr,
"Error reading secrets from jetpack cloud: %s\n\n",
err,
)
} else {
for _, secret := range cloudSecrets {
env[secret.Name] = secret.Value
}
}
}
} else if d.cfg.EnvFrom != "" {
Expand Down