Skip to content

[state] Ignore shell mismatch for run #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

mikeland73
Copy link
Contributor

Summary

This is a bit hacky, but was smallest, safest I could come up with. This fixes the following case:

  • User uses fish as shell
  • User adds devbox run in their init hook
  • User gets warning that environment is stale. This happens because shell doesn't match, but we don't really care that shell doesn't match for run. We only care for shell because we use different shellrc for fish vs POSIX.

How was it tested?

Added devbox run echo foo to init hook. Then ran

SHELL=fish devbox run echo bar

@mikeland73 mikeland73 requested review from gcurtis and savil February 1, 2024 22:22
Copy link
Collaborator

@savil savil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, yes, this solve it :)

@mikeland73 mikeland73 merged commit f050ab8 into main Feb 2, 2024
@mikeland73 mikeland73 deleted the landau/dont-check-shell-mismatch branch February 2, 2024 00:08
Copy link

sentry-io bot commented Feb 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **syscall.Errno: error running script in Devbox: <redacted errors.withStack>: <redacted os.Lin... go.jetpack.io/devbox/internal/plugin in createS... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants