Revert "nix: improve redacted nix error (#1776)"

[savil]

Summary

Reason for reverting: to omit this PR from the Devbox release.

When I run devbox run -- DEVBOX_DEBUG=1 go test -v -run TestScripts/global ./testscripts/... on my Mac with nix 2.20, I get this error.
The output below is from main that includes this redacted-error improvement PR #1776

      2024/02/02 17:15:34 Running print-dev-env cmd: /nix/var/nix/profiles/default/bin/nix print-dev-env /var/folders/zv/r3sx92_94gq86_rq3yn1ky2h0000gn/T/TestScripts4205203385/001/.local/share/devbox/global/default/.devbox/gen/flake --extra-experimental-features ca-derivations --option experimental-features nix-command flakes fetch-closure --json
        Error: nix command: [nix print-dev-env <redacted path> --extra-experimental-features ca-derivations --option experimental-features nix-command flakes fetch-closure --json]

        2024/02/02 17:15:34
        ExecutionID:75d13152cb3f4b089677cfe7ef08a2c4
        nix command: [nix print-dev-env <redacted path> --extra-experimental-features ca-derivations --option experimental-features nix-command flakes fetch-closure --json]
        go.jetpack.io/devbox/internal/nix.(*Nix).PrintDevEnv
        	/Users/savil/code/jetpack/devbox/internal/nix/nix.go:87
        go.jetpack.io/devbox/internal/devbox.(*Devbox).computeEnv
        	/Users/savil/code/jetpack/devbox/internal/devbox/devbox.go:831

but prior to this redact PR, the error message was the following which makes diagnosis of the error possible:

        Error: Command: /nix/var/nix/profiles/default/bin/nix print-dev-env /var/folders/zv/r3sx92_94gq86_rq3yn1ky2h0000gn/T/TestScripts1786708027/001/.local/share/devbox/global/default/.devbox/gen/flake --extra-experimental-features ca-derivations --option experimental-features nix-command flakes fetch-closure --json: exit status 1

        2024/02/02 17:18:51 Command stderr: error (ignored): error: end of string reached
        error:
               … while fetching the input 'path:/var/folders/zv/r3sx92_94gq86_rq3yn1ky2h0000gn/T/TestScripts1786708027/001/.local/share/devbox/global/default/.devbox/gen/flake'

               error: path '«unknown»/var' is a symlink

        2024/02/02 17:18:51
        ExecutionID:4cf67968924744ea918169a68b1cb44f
        exit status 1
        Command: /nix/var/nix/profiles/default/bin/nix print-dev-env /var/folders/zv/r3sx92_94gq86_rq3yn1ky2h0000gn/T/TestScripts1786708027/001/.local/share/devbox/global/default/.devbox/gen/flake --extra-experimental-features ca-derivations --option experimental-features nix-command flakes fetch-closure --json
        go.jetpack.io/devbox/internal/nix.(*Nix).PrintDevEnv
        	/Users/savil/code/jetpack/devbox/internal/nix/nix.go:79
        go.jetpack.io/devbox/internal/devbox.(*Devbox).computeEnv
        	/Users/savil/code/jetpack/devbox/internal/devbox/devbox.go:831

How was it tested?

[savil]

Current dependencies on/for this PR:

• main
  • PR Revert "nix: improve redacted nix error (#1776)" #1778 👈

This stack of pull requests is managed by Graphite.

[gcurtis]

I fumbled this with the original PR. I was going to try and sanitize the individual args, but then decided not to and ended up with a weird in between implementation. The line was supposed to just be:

redact.Errorf("nix command: %s", redact.Safe(cmd))

and not have the safeArgs stuff.

Redacted error messages are not normally redacted and retain their normal message unless they're sent to Sentry. But here I modified the actual slice of args, so it ended up always redacted.

If this isn't blocking anything, I can just submit a fix PR later.

[savil]

I think I see. I need to learn about our redact logic more.

Assuming it's okay, I'm going to land this, just so that the Devbox release is unblocked. Since it's a small PR, perhaps you could re-submit with the better fix and if it works out timing-wise then it could be included in the release as well!

[gcurtis]

@savil fixed in #1782.