ISSUE-144: allow schema object property name contains any character #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perviously we have a validation forcing all output object property name to be only alpha-numeric (plus underscore). Turns out we have use cases where the property name might contains special characters such as `'$'` or `'%'`, or `'.'`. Loosen up the restriction and dealing with all special character in property name (thus in FQDN) properly with escaping/unescaping.
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 1983 1983
=========================================
Hits 1983 1983
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perviously we have a validation forcing all output object property name to be only alpha-numeric (plus underscore). Turns out we have use cases where the property name might contains special characters such as
'$'or'%', or'.'.Loosen up the restriction and dealing with all special character in property name (thus in FQDN) properly with escaping/unescaping.
FYI @Plenituz, once it's merged, will publish a new release.