-
Notifications
You must be signed in to change notification settings - Fork 1
feature: query lineage visualizer for general case #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments on some small things. You may need to run git pull --rebase
, since the diff claims you changed jumpstart.rst
and _repack_model.py`, when I'm pretty sure those are brought in from the recent merge from the tracking aws/sagemaker-python-sdk.
7359b3d
to
fd97f65
Compare
Looks good! Could you add a sample screenshot of the graph to the pr description? |
edge.association_type added style changes of graph DashVisualizer class added Try except when importing visual modules
Merge pull request #3 from ytlee93/master
Merge pull request #5 from ytlee93/master
Issue #, if available:
Description of changes: added query lineage visualizer for general startarn case

rendered graph sample
Testing done:
tox -e black-format & tox -e flake8,pylint,twine,black-check,docstyle --parallel all
tox -e py39 tests/unit/sagemaker/lineage
tox -e py39 tests/integ/sagemaker/lineage
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.