Config tweaks #2
Conversation
These lines were originally added before 1.0 when a local Mongo Orchestration process was used to create the test environments (see: PHPC-128).
If a directory is excluded, a negation on the files within it (e.g. "!dir/*") has no effect. Since .travis.scripts/ is excluded by ".*", we need to negate the directory itself to ensure the files within are tracked.
This was last updated in 90a64b4 when the project was hosted in the 10gen-labs groups.
PHP 5.4 was the last version where run-tests.php failed to report a non-zero exit code after a failure. Since the extension requires 5.5+, we can rely on any existing run-tests.php file.
Travis' backlog for macOS builds is quite high, and the environments also do not support MongoDB. We can revisit adding these environments down the line when the infrastructure has improved and we sort out explicit installation of MongoDB versions (see: PHPLIB-299). Note: a macOS build with Secure Channel was manually tested in mongodb#736.
config.m4
Outdated
| PHP_ARG_ENABLE(mongodb, whether to enable mongodb support, | ||
| [ --enable-mongodb Enable mongodb support]) | ||
| PHP_ARG_ENABLE(mongodb, whether to enable MongoDB support, | ||
| [ --enable-mongodb Enable MongoDB support]) |
There was a problem hiding this comment.
These should really use AC_HELP_STRING. Would you like to re-work this commit? Otherwise, pull it out entirely and I'll address this in my original PR.
There was a problem hiding this comment.
AC_HELP_STRING is something I had not encountered before. I don't see any other PHP extensions using it. It was actually working against me, as originally I wanted to indent all the dependent settings with two extra spaces, but m4 seems to remove beginning white space from the string...
There was a problem hiding this comment.
I'm not surprised that other PHP extensions don't use it, but I think it's worth using in our case since we have so many options and their help text often runs multiple lines. See: https://autotools.io/autoconf/arguments.html#autoconf.arguments.helpstrings
There are some other benefits aside from formatting.
derickr
force-pushed
the
config-tweaks
branch
from
fdf9563 to
ec58469
Compare
| PHP_ARG_WITH(libmongoc, whether to use system libmongoc, | ||
| [ --with-libmongoc Use system libmongoc], no, no) | ||
| [ --with-libmongoc MongoDB: Use system libmongoc], no, no) |
There was a problem hiding this comment.
Missing AC_HELP_STRING for these and mongodb-sasl below. I'll take care of that myself.
|
I've merged this into my branch and the commits are now in mongodb#736. |
No description provided.