Update ignore mechanism to use a file rather than altering the script #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Pull
Add ability to ignore everything listed in a specified file.
jonreid
added a commit
that referenced
this pull request
Dec 25, 2015
Update ignore mechanism to use a file rather than altering the script
|
Thank you! Sorry it took me so long to get to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep using this as a CocoaPod, we needed to update the mechanism for ignoring certain files to not require editing the script file - otherwise it would be overwritten by any
pod installorpod update. This isn't just confined to CocoaPods: This same problem would even apply to anyone using this as a submodule and trying to apply an update.I've added (with lots of Bash help from my colleague @vokal-isaac) a mechanism to check for a
.xcodecoverageignorefile at theSRCROOTlevel, which will allow users to specify what files or folders they wish to ignore. That way this script can be updated over and over and over again without overwriting the list of ignored files or folders, and the.xcodecoverageignorefile can be committed to version control for use in continuous integration.If this passes muster, would be awesome if you could merge and tag as 1.3.0 - I updated the changelog to reflect that as an anticipated version number. Would love any feedback!