-
Notifications
You must be signed in to change notification settings - Fork 476
Core: Remove support for jQuery 4.x #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3ae8ed6
Core: Remove support for jQuery 4.x
mgol 8d20816
Core: Don't reimplement deprecated but not removed APIs
mgol 75c35bc
Attributes: Update warnings.md to not mention jQuery 4.0
mgol 946c36f
Build: Rename more `main`s to `3.x-stable`s
mgol 7f1aa21
Event: Reimplement APIs deprecated in jQuery 3.0/3.1
mgol 182359f
Tests: Test on jQuery 3.1.1.slim in non-BrowserStack browser tests
mgol e891cfc
Build: Stop testing on iOS 10
mgol fb1f74b
Build: Update a vulnerable dependency
mgol 5505f7f
Core: Update the package.json description
mgol 4a66dab
Docs: Link to jQuery Browser Support page in README.md
mgol cf6a09e
Docs: Address code review remarks
mgol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ on: | |
pull_request: | ||
push: | ||
branches: | ||
- main | ||
- 3.x-stable | ||
|
||
env: | ||
NODE_VERSION: 22.x | ||
|
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,7 @@ Make sure you have reproduced the bug with all browser extensions and add-ons di | |
|
||
### Try the latest version of jQuery Migrate | ||
|
||
Bugs in old versions of jQuery Migrate may have already been fixed. In order to avoid reporting known issues, make sure you are always testing against the [latest build](https://releases.jquery.com/git/jquery-migrate-git.js). We cannot fix bugs in older released files, if a bug has been fixed in a subsequent version of jQuery Migrate the site should upgrade. | ||
Bugs in old versions of jQuery Migrate may have already been fixed. In order to avoid reporting known issues, make sure you are always testing against the [latest build](https://releases.jquery.com/git/jquery-migrate-3.x-git.js). We cannot fix bugs in older released files, if a bug has been fixed in a subsequent version of jQuery Migrate the site should upgrade. | ||
|
||
### Simplify the test case | ||
|
||
|
@@ -78,16 +78,16 @@ Change directory to the newly created dir `jquery-migrate/`: | |
$ cd jquery-migrate | ||
``` | ||
|
||
Add the jQuery Migrate `main` as a remote (e.g. `upstream`): | ||
Add the jQuery Migrate `3.x-stable` as a remote (e.g. `upstream`): | ||
|
||
```bash | ||
$ git remote add upstream [email protected]:jquery/jquery-migrate.git | ||
``` | ||
|
||
Get in the habit of pulling in the "upstream" main to stay up to date as jQuery Migrate receives new commits: | ||
Get in the habit of pulling in the "upstream" `3.x-stable` to stay up to date as jQuery Migrate receives new commits: | ||
|
||
```bash | ||
$ git pull upstream main | ||
$ git pull upstream 3.x-stable | ||
``` | ||
|
||
Install the necessary dependencies: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ var releaseVersion, | |
prompt = enquirer.prompt, | ||
|
||
repoURL = "[email protected]:jquery/jquery-migrate.git", | ||
branch = "main", | ||
branch = "3.x-stable", | ||
|
||
// Windows needs the .cmd version but will find the non-.cmd | ||
// On Windows, also ensure the HOME environment variable is set | ||
|
@@ -211,7 +211,7 @@ async function publishToNPM( next ) { | |
|
||
function setNextVersion( next ) { | ||
updateSourceVersion( nextVersion ); | ||
updatePackageVersion( nextVersion, "main" ); | ||
updatePackageVersion( nextVersion, "3.x-stable" ); | ||
git( [ "commit", "-a", "--no-verify", "-m", "Updating the source version to " + nextVersion ], | ||
next ); | ||
} | ||
|
@@ -281,7 +281,7 @@ function updateReadmeVersion() { | |
} | ||
|
||
function setBlobVersion( s, v ) { | ||
return s.replace( /\/blob\/(?:(\d+\.\d+[^\/]+)|main)/, "/blob/" + v ); | ||
return s.replace( /\/blob\/(?:(\d+\.\d+[^\/]+)|3.x-stable)/, "/blob/" + v ); | ||
} | ||
|
||
function writeJsonSync( fname, json ) { | ||
|
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.