Focusable: Fix handling of visibility: collapse
#1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"collapse" is similar to "hidden", with a slight difference in the case of tr/tbody/td/colgroup elements. See https://www.w3.org/TR/CSS22/visufx.html#visibility See https://www.w3.org/TR/CSS22/tables.html#dynamic-effects See https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Table_example "visibility: collapse" elements are always not focusable, though. Commit d302596 introduced a regression by testing with `!== "hidden"` instead of `=== "visible"`.
|
|
|
Any chance this will eventually get reviewed (and, hopefully, merged)? It’s been 3 years. |
|
with 41 open PR's i feel like activity on Jquery UI is very slow to get merged but 3 years is a little excessive. Hopefully this will get merged before 1.13 is released! |
melloware
approved these changes
Sep 30, 2020
fnagel
approved these changes
Oct 14, 2020
|
Landed, thank you! |
|
Great, dziękuję! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"collapse" is similar to "hidden", with a slight difference in the case of
tr/tbody/td/colgroupelements.See https://www.w3.org/TR/CSS22/visufx.html#visibility
See https://www.w3.org/TR/CSS22/tables.html#dynamic-effects
See https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Table_example
"visibility: collapse" elements are always not focusable, though.
Commit d302596 introduced this regression by testing with
!== "hidden"instead of=== "visible".