Skip to content

Datepicker: Fix Hungarian localization to use uppercase for first characters #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

Datepicker: Fix Hungarian localization to use uppercase for first characters #1903

merged 1 commit into from
Mar 23, 2020

Conversation

zsoltii
Copy link
Contributor

@zsoltii zsoltii commented Dec 18, 2019

Apply Hungarian language rules on datepicker Hungarian translation.

@jsf-clabot
Copy link

jsf-clabot commented Dec 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fnagel
Copy link
Member

fnagel commented Jan 14, 2020

@zsoltii Thanks for your contribution!

So, this PR basically a ucfirst() for the control labels, right? Any idea why those were lower case until now?

@fnagel fnagel self-assigned this Jan 14, 2020
@fnagel fnagel self-requested a review January 14, 2020 08:46
fnagel
fnagel requested changes Jan 14, 2020
View reviewed changes
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change commit message to "Datepicker: Fix Hungarian localization to use uppercase for first characters"

@zsoltii zsoltii changed the title Apply Hungarian language rules Datepicker: Fix Hungarian localization to use uppercase for first characters Jan 15, 2020
@zsoltii zsoltii requested a review from fnagel January 15, 2020 08:39
fnagel
fnagel approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and will be merged soon!

@fnagel
Copy link
Member

fnagel commented Mar 23, 2020

For the record: asked a Hungarian friend and he approves this change.

@fnagel fnagel merged commit 9bb366e into jquery:master Mar 23, 2020
@mgol mgol added this to the 1.13 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnagel fnagel fnagel approved these changes

Assignees

@fnagel fnagel

Labels
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zsoltii @jsf-clabot @fnagel @mgol