loadRelations loop

[Patrik-Lundqvist]

Loading a second level of nested relations seems to create an infinite loop

Example:

// Load first customer
var customer1 = DS.get('customer', 1);

// Load the customers projects
DS.loadRelations('customer', customer1, ['project']).then(function () {
    var project1 = DS.get('project', 1);

    // Load the projects items
    DS.loadRelations('project', project1, ['item']);
});

Loading the projects items creates a loop which freezes the browser

[jmdobry]

@Patrik-Lundqvist Can I see how you've defined the relations for these resources?

[Patrik-Lundqvist]

Yes of course

DS.defineResource({
    name: 'customer',
    endpoint: 'customers',
    relations: {
        belongsTo: {
            organization: {
                parent: true,
                localKey: 'organizationId',
                localField: 'organization'
            }
        },
        hasMany: {
            project: {
                localField: 'projects',
                foreignKey: 'customerId'
            }
        }
    }
});

DS.defineResource({
    name: 'project',
    endpoint: 'projects',
    relations: {
        belongsTo: {
            customer: {
                parent: true,
                localKey: 'customerId',
                localField: 'customer'
            }
        },
        hasMany: {
            item: {
                localField: 'items',
                foreignKey: 'projectId'
            }
        }
    }
});

DS.defineResource({
    name: 'item',
    endpoint: 'items',
    relations: {
        belongsTo: {
            project: {
                parent: true,
                localKey: 'projectId',
                localField: 'project'
            }
        }
    }
});

Here is the logged error: http://pastebin.com/ntbCMbdn

[jmdobry]

@Patrik-Lundqvist The test I added in the above commit seems to reflect the relations you described, and it passes. At this point I would need you to create a Plunkr or JSBin which I can debug.

[Patrik-Lundqvist]

The problem was in my data from the api. The returned item json object had a nested foreign key relation which caused this problem.

Example:

// This data will cause the problem
{
    "id": 1,
    "name": "Item1",
    "projectId": 1,
    "project": {
      "id": 1
    }
}

// This will not
{
    "id": 1,
    "name": "Item1",
    "projectId": 1
}

Handling of nested foreign key relations in returned data should probably be its own issue.

[jmdobry]

It should have worked with the nested data. I'll investigate that.

[jmdobry]

@Patrik-Lundqvist Actually, can you post here what endpoints were hit (the urls) and what data was returned by each?

[Patrik-Lundqvist]

Here is a plunker displaying the error: http://plnkr.co/edit/U7j42d?p=preview

[jmdobry]

Thanks