Supporting methods on model instances

[chadwithuhc]

I would like to see the same save(), destroy(), etc. on the returned item instances by default. Is there currently a reason why they aren't?

// Example code
ModelName.find(1).then(function (item) {
  item.destroy();
});

For the mean time I am adding them with defineResource().

var Model = DS.defineResource({
    name: 'subjects',
    methods: {
      destroy: function () {
        return Model.destroy(this.id);
      }
    }
  });

[jmdobry]

Sorry I haven't documented this better, but I already added save and update to the default instance methods, though they are named DSSave and DSUpdate to avoid stomping on any save or update methods developers might want to add.

I haven't added DSDestroy yet, but I will. I will also add DSRefresh. I'll use this issue to remind me to do that.

Example:

var user = User.inject({ id: 1 });

user.DSUpdate({ name: 'john' }).then(function (user) {
  user; // { id: 1, name: 'john' }
});

[chadwithuhc]

I'd prefer it to be the simple method names save, update, destroy, etc. instead of the DS ones. You could put them on the prototype and let theirs override it.

It just seems weird to have it .save() in one place and .DSSave() in another.

[jmdobry]

It's a valid point.

However, I made it a point to namespace anything I put on the instance prototype (read: get out of the developer's way) to avoid any potential naming conflicts with something a developer wants to do. That's how it will be going forward. :)

[chadwithuhc]

Thanks for knocking this out so fast @jmdobry ! Got the updates in my repo now and they're great.

[mrrooijen]

@jmdobry any plans to add DSLoadRelations?

organization.DSLoadRelations(["membership", "user"])

Less verbose than:

DS.loadRelations("organization", organization.id, ["membership", "user"])

And doesn't require injection of the DS dependency, plus would be more consistent with the other methods such as DSSave, DSUpdate, DSDestroy, DSRefresh, etc.

[jmdobry]

Forgot about that one. I will add it.

[mrrooijen]

@jmdobry awesome, thanks! :)

[ghelton]

Is it possible to add DSEject as well?

[jmdobry]

Sure