Webpack has compiled the call to axios adapters wrongly

[tmoitie]

https://github.com/js-data/js-data-http/blob/master/dist/js-data-http.js#L790-L794

The code on line 790 and 794 should be different, but instead both call the same reference (The XHR adapter). It means that any calls to js-data-http in NodeJS fail.

I have tried to recompile the library but I'm getting a "Unexpected reserved word" failure - looks like I can't get the babel-loader to work properly on my end.

[jmdobry]

I am investigating.

[analytik]

I think I might be experiencing a related issue. Using node.js 4.1.1, js-data 2.4.0, js-data-http 2.1.1.

Module 19 is defined as

/* 19 */
/***/ function(module, exports) {

    /* (ignored) */

/***/ },

but then since it's used like this:

        function lib$es6$promise$asap$$attemptVertex() {
          try {
            var r = require;
            var vertx = __webpack_require__(19);
              console.log(vertx);
            lib$es6$promise$asap$$vertxNext = vertx.runOnLoop || vertx.runOnContext;
            return lib$es6$promise$asap$$useVertxTimer();
          } catch(e) {
            return lib$es6$promise$asap$$useSetTimeout();
          }
        }

both vertx.runOnLoop and vertx.runOnContext are undefined, and I'm getting this error:

TypeError: lib$es6$promise$asap$$vertxNext is not a function
    at d:\project\node_modules\js-data-http\dist\js-data-http.js:1467:10
    at asap (d:\project\node_modules\js-data-http\dist\js-data-http.js:1427:12)
    at lib$es6$promise$promise$$Promise.then (d:\project\node_modules\js-data-http\dist\js-data-http.js:2268:12)
    at DSHttpAdapter.axios [as http] (d:\project\node_modules\js-data-http\dist\js-data-http.js:471:24)
    at DSHttpAdapter.HTTP (d:\project\node_modules\js-data-http\dist\js-data-http.js:270:20)
    at DSHttpAdapter.GET (d:\project\node_modules\js-data-http\dist\js-data-http.js:281:20)
    at DSHttpAdapter.find (d:\project\node_modules\js-data-http\dist\js-data-http.js:320:21)
    at d:\project\node_modules\js-data\dist\js-data-debug.js:4612:46
    at process._tickCallback (node.js:356:9)

I am using js-data-rethinkdb successfully, but then I tried added js-data-http for another model, and I get the above error when I try a simple SomeModel.find(someId).then(...).

This seems to be a (relatively) common problem with vertx and webpack, it seems? webpack/webpack#353

EDIT: seems there's a whole bunch of browser-only stuff included in compiled js-data-http, like trying to use window object, XMLHttpRequest, etc, but I guess that's all related?

EDIT 2: When I check out the git repo and try to do npm install, bower install and grunt test, I get

Running "clean:coverage" (clean) task
>> 0 paths cleaned.

Running "clean:dist" (clean) task
>> 1 path cleaned.

Running "standard" task
Linting for correcting formatting...

Done linting.

Running "webpack:dist" (webpack) task
Version: webpack 1.12.2
                 Asset   Size  Chunks             Chunk Names
./dist/js-data-http.js  38 kB       0  [emitted]  main

Running "uglify:main" (uglify) task
JS_Parse_Error {
  message: 'Unexpected token: name (JSData)',
  filename: 'js-data-http.js',
  line: 66,
  col: 5,
  pos: 2171,
  stack: 'Error
    at new JS_Parse_Error (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:196:18)
    at js_error (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:204:11)
    at croak (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:680:9)
    at token_error (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:688:9)
    at unexpected (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:694:9)
    at semicolon (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:714:43)
    at simple_statement (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:894:73)
    at d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:767:19
    at d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:727:24
    at block_ (d:\\project\\node_modules\\js-data-http\\node_modules\\uglify-js\\lib\\parse.js:1007:20)' }
>> Uglifying source dist/js-data-http.js failed.
Warning: Uglification failed.
Unexpected token: name (JSData).
Line 66 in dist/js-data-http.js
 Use --force to continue.

Aborted due to warnings.

[jmdobry]

There are currently problems with getting js-data-http to run on Node.

[analytik]

Ah, thanks for the confirmation. I'm still too new to the whole ecosystem out to be of any actual help, but I'll be glad to help with testing whenever something is ready.

[jmdobry]

Fixed in 3.0.0-alpha.1. Published js-data-http-node to NPM which works on Node.js, while js-data-http only works in the browser.

[SystemParadox]

Ugh. Why the separate package? Surely there is a better way to fix this? What's actually the issue here?