Fix pull to refresh logic #17
Conversation
|
@jsdf could you take a look over this? It contains major improvements in my oppinion. |
|
Sorry, I'm a bit busy at the moment so I'll get back to you soon. However from initially looking over it I think I'd probably like to implement a fix in a slightly different way. However I appreciate your bringing theses issues to my attention. |
| @@ -37,7 +38,16 @@ var ControlledRefreshableListView = React.createClass({ | |||
| handleScroll(e) { | |||
| var scrollY = e.nativeEvent.contentInset.top + e.nativeEvent.contentOffset.y | |||
|
|
|||
| if (!(this.props.ignoreInertialScroll && this.isTouching)) { | |||
| if (scrollY == 0 && this.scrollingUp && !this.isTouching) { | |||
There was a problem hiding this comment.
Lines 41-48 tells me when the user stops pulling and the scroll goes back to 0. Only then I set isRefreshing to false. Lines 46-48 were necesary because if I update the list while user is pulling, scroll position is set to 0 and then gets back to last position.
|
Merge this please, this bug is really annoying me ( |
|
I switched to https://github.com/Shuangzuan/RCTRefreshControl . It still
|
|
Thanks! |
This fix contains a fix for this issue: #16
It also keeps the list refreshing until the user is not touching. Without this fix, one could pull & hold and the refresh function would be triggered multiple times.