Flesh out some more ignore cases for object validators. #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some languages have sequence types covering hash maps, arrays, and strings. Make sure those languages properly notice to ignore these validators on non-objects.
epoberezkin
approved these changes
Jun 20, 2017
|
Thanks! |
|
Quite a few JavaScript validators fail some of these tests btw. |
|
Interesting... Glad then we added them I guess?
…On Jun 24, 2017 05:07, "Evgeny Poberezkin" ***@***.***> wrote:
Quite a few JavaScript validators fail some of these tests btw.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUIXkEWrzV5t6Y_nq2iUVTsQfshu_t0ks5sHNHggaJpZM4N9gkj>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages have sequence types covering hash maps,
arrays, and strings. Make sure those languages properly
notice to ignore these validators on non-objects.
Closes #187
@epoberezkin if you have a second?