feat: test draft-7 with Ajv #207
Merged
+30
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
force-pushed
the
draft-7-ajv
branch
from
a35be56 to
3d9830a
Compare
|
@epoberezkin please file the format split thing as a separate issue if it is not already and we can discuss it there. A PR is not the place to discuss other changes. |
handrews
approved these changes
Nov 27, 2017
| format: 'full', | ||
| formats: {'json-pointer': /^(?:\/(?:[^~\/]|~0|~1)*)*$/} |
There was a problem hiding this comment.
I'm assuming this is removed because you now recognize the json-pointer format automatically?
There was a problem hiding this comment.
Previously json-pointer format in ajv allowed hash-fragment encoding, so it had to be replaced. Now it is changed, so no need to replace it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've skipped tests optional/content and optional/format (content keywords and new international formats aren't part of ajv, I hope I or somebody else will make plugins to support them, then I can add them back).
Could we maybe split formats to multiple files as we've discussed (or at least two files)? It would be possible to exclude only those unsupported at the moment.