Skip to content

feat: test draft-7 with Ajv #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2017
Merged

feat: test draft-7 with Ajv #207

merged 1 commit into from
Nov 28, 2017

Conversation

epoberezkin
Copy link
Member

I've skipped tests optional/content and optional/format (content keywords and new international formats aren't part of ajv, I hope I or somebody else will make plugins to support them, then I can add them back).
Could we maybe split formats to multiple files as we've discussed (or at least two files)? It would be possible to exclude only those unsupported at the moment.

@epoberezkin epoberezkin requested a review from handrews November 27, 2017 22:39
@handrews
Copy link
Contributor

@epoberezkin please file the format split thing as a separate issue if it is not already and we can discuss it there. A PR is not the place to discuss other changes.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- one comment because I don't quite understand what was going on with that line, but it's not a blocker.

Thanks for catching the test file $schema draft changes.

format: 'full',
formats: {'json-pointer': /^(?:\/(?:[^~\/]|~0|~1)*)*$/}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is removed because you now recognize the json-pointer format automatically?

Copy link
Member Author

@epoberezkin epoberezkin Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously json-pointer format in ajv allowed hash-fragment encoding, so it had to be replaced. Now it is changed, so no need to replace it.

@epoberezkin epoberezkin merged commit 870b9f7 into master Nov 28, 2017
@epoberezkin epoberezkin deleted the draft-7-ajv branch November 28, 2017 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants