Fix invalid IPv6 IRI #213
Merged
Fix invalid IPv6 IRI #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vearutop
suggested changes
Jan 24, 2018
| @@ -25,9 +25,14 @@ | |||
| }, | |||
| { | |||
| "description": "a valid IRI based on IPv6", | |||
| "data": "http://2001:0db8:85a3:0000:0000:8a2e:0370:7334", | |||
| "data": "http://[2001:0db8:85a3:0000:0000:8a2e:0370]:7334", | |||
There was a problem hiding this comment.
This is not a valid IRI as 2001:0db8:85a3:0000:0000:8a2e:0370 is not a valid IPv6 (8 segments required).
http://[2001:0db8:85a3:0000:0000:8a2e:0370:7334] this is correct IRI (:7334 is not a port).
There was a problem hiding this comment.
Good catch! Thanks @vearutop
IPv6 URIs (and IRIs) require square brackets around the IP address. https://tools.ietf.org/html/rfc3986#section-3.2.2 > A host identified by an Internet Protocol literal address, version 6 > [RFC3513] or later, is distinguished by enclosing the IP literal > within square brackets ("[" and "]"). This is the only place where > square bracket characters are allowed in the URI syntax.
davishmcclurg
force-pushed
the
ipv6-iri-format
branch
from
55377ec to
2146b02
Compare
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
Jan 30, 2018
Fix is taking longer than expected: json-schema-org/JSON-Schema-Test-Suite#213
|
Thanks! Sorry I hadn't noticed this PR, I just found out my spam filter's been eating some random percentage of GitHub notification :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 URIs (and IRIs) require square brackets around the IP address.
https://tools.ietf.org/html/rfc3986#section-3.2.2