Skip to content

test false-exclusivity for max/min numbers #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2018
Merged

test false-exclusivity for max/min numbers #220

merged 1 commit into from
May 1, 2018

Conversation

pboettch
Copy link
Contributor

My C++ schema validator was not working correctly when exclusiveMinimum or exclusiveMinimum was set to false. Adding a test for explicit false-testing.

@pboettch pboettch changed the title test fasle-exclusivity for max/min numbers test falsee-exclusivity for max/min numbers Apr 25, 2018
@pboettch pboettch changed the title test falsee-exclusivity for max/min numbers test false-exclusivity for max/min numbers Apr 25, 2018
awwright
awwright approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@awwright awwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct!

@Julian
Copy link
Member

Julian commented May 1, 2018

Thanks!

@Julian Julian merged commit ff448af into json-schema-org:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awwright awwright awwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pboettch @Julian @awwright