Skip to content

Escaped characters in schemas #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2019
Merged

Escaped characters in schemas #259

merged 5 commits into from
Mar 31, 2019

Conversation

epoberezkin
Copy link
Member

No description provided.

@epoberezkin epoberezkin requested a review from Julian March 30, 2019 20:43
@Julian
Copy link
Member

Julian commented Mar 31, 2019

Hooray! Thanks.

@Julian Julian merged commit 15ba997 into json-schema-org:master Mar 31, 2019
@epoberezkin epoberezkin deleted the epoberezkin/special-chars branch April 7, 2019 19:34
@leadpony
Copy link
Contributor

leadpony commented Apr 13, 2019

Hello @epoberezkin and @Julian. Thank you for providing great tests for us!

The commit ref with quote contained in this PR arose a question.
According to the metaschema, $ref keyword can only accept a value, whose format is uri-reference. And the RFC 3986 does not permit quotation mark (U+0022) in the fragment part of URI reference, unless the character is percent-encoded.
Therefore the given schema is not evaluated as valid by validators which understand format keyword.

"$ref": "#/definitions/foo\"bar"

should be

"$ref": "#/definitions/foo%22bar"

But this modification to the test case may cause a problem for validators which does not process the value of "$ref" as a URI reference.
Any idea for this problem?

@Julian
Copy link
Member

Julian commented Apr 14, 2019

Hey -- I can have a look and double check, could you open a separate issue so it's easier to keep track? Appreciated!

I think the tests for the suite should have caught that, but yeah happy to verify.

@leadpony
Copy link
Contributor

I have posted a separate issue #261 for this.
Thank you @Julian .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants