Add nested allOf, oneOf tests #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thank you! Do you think you could copy these backwards to the older drafts too? |
|
I didn't see them in older drafts, but sure I can backport them if you can give me a couple days. |
|
Cool thanks, will have a look myself as well if I get some spare cycles before then. |
|
@Julian Done |
|
Woohoo! lgtm thanks again! |
|
Is this ready for merge? |
|
@awwright yes definitely! |
|
@Julian You wanna push the button since I made the PR? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the comparable test found in "anyOf" was failing on my validator; I added these to ensure that allOf & oneOf were also working similarly (they weren't).
Filing upstream for great posterity.