more tests for true != 1 and false != 0 inside objects/arrays #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks great. Can you help backport these (copy them) to the previous drafts they apply to as well? Thanks! |
|
Sure thing! |
|
I backported the const cases to draft6 and the uniqueItems to draft3. |
Julian
reviewed
Jun 11, 2020
| @@ -125,6 +125,90 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "description": "const with [false] does not match [0]", | |||
| "schema": {"const": [false]}, | |||
There was a problem hiding this comment.
Should these also be added to enum? Likely there's the same test gap there as here since these are new extra cases.
There was a problem hiding this comment.
(And that would apply all the way back to old drafts if so)
Julian
added a commit
that referenced
this pull request
Aug 13, 2020
Stray bracket comes from copypastaing the array tests here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.