Skip to content

some more tests for the "duration" format #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2020
Merged

some more tests for the "duration" format #412

merged 1 commit into from
Jul 11, 2020
+116 −0

Conversation

karenetheridge
Copy link
Member

These are the non-controversial bits extracted out of #402.

@karenetheridge karenetheridge requested a review from a team July 4, 2020 18:44
@karenetheridge karenetheridge mentioned this pull request Jul 4, 2020
Closed
Julian
Julian approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@Julian Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karenetheridge karenetheridge merged commit 8ccbfdc into master Jul 11, 2020
@karenetheridge karenetheridge deleted the ether/more-format-duration-2 branch July 11, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian Julian Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karenetheridge @Julian