Skip to content

More test cases for email format according to RFC-5321 section 4.1.2. #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

More test cases for email format according to RFC-5321 section 4.1.2. #466

wants to merge 1 commit into from

Conversation

gene-hightower
Copy link

No description provided.

@karenetheridge
Copy link
Member

I have no opinion as to whether these new tests are correct. (FWIW, my implementation fails the last two - "invalid domain" and "invalid IPv4-address-literal"). However, before we merge, the tests should be added to all relevant drafts -- tests/draft*/optional/format/email.json.

@Julian
Copy link
Member

Julian commented Mar 19, 2021

My implementation will consider all of these to be valid, so I too have no real opinion -- this is a file in optional, and the spec allows implementations to decide whether they want to support email as a format via the exact RFC definition or some broader one -- if these merge, as an implementer I'd just skip all the ones marked invalid (so yeah I'm fine with merging these of course if others want them).

@gene-hightower
Copy link
Author

I guess maybe I should double check which "draft" these tests should apply to? Maybe draft2019-09 is not correct, but draft2020-12 is?

@gene-hightower
Copy link
Author

If fact, I think that is the case. The tests I think are valid for the 2020-12 draft (based on RFC-5321), but perhaps not other drafts (which may have had other advise)

@karenetheridge
Copy link
Member

xref: #467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants