more test cases for unevaluatedItems, unevaluatedProperties #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
added a commit
to karenetheridge/JSON-Schema-Modern
that referenced
this pull request
Apr 6, 2021
This prevents annotations collected so far from being improperly used by unevaluatedItems, unevaluatedProperties when only annotations from sibling keywords (or children of sibling keywords) should be used. See https://stackoverflow.com/questions/66936884/deeply-nested-unevaluatedproperties-and-their-expectations and json-schema-org/JSON-Schema-Test-Suite#472
karenetheridge
added a commit
to karenetheridge/JSON-Schema-Modern
that referenced
this pull request
Apr 6, 2021
This prevents annotations collected so far from being improperly used by unevaluatedItems, unevaluatedProperties when only annotations from sibling keywords (or children of sibling keywords) should be used. See https://stackoverflow.com/questions/66936884/deeply-nested-unevaluatedproperties-and-their-expectations and json-schema-org/JSON-Schema-Test-Suite#472
jdesrosiers
reviewed
Apr 6, 2021
marksparkza
reviewed
Apr 7, 2021
| ] | ||
| }, | ||
| { | ||
| "description": "item is evaluated in an uncle schema to unevaluatedItems", |
There was a problem hiding this comment.
Suggested change
| "description": "item is evaluated in an uncle schema to unevaluatedItems", | |
| "description": "item is evaluated in a separate keyword branch to unevaluatedItems", |
marksparkza
reviewed
Apr 7, 2021
| "valid": true | ||
| }, | ||
| { | ||
| "description": "uncle keyword evaluation is not significant", |
There was a problem hiding this comment.
Suggested change
| "description": "uncle keyword evaluation is not significant", | |
| "description": "evaluation of items in a separate keyword branch is not significant", |
marksparkza
reviewed
Apr 7, 2021
| ] | ||
| }, | ||
| { | ||
| "description": "in-place applicator siblings, allOf has unevaluated", |
There was a problem hiding this comment.
Suggested change
| "description": "in-place applicator siblings, allOf has unevaluated", | |
| "description": "property is evaluated in a separate keyword branch to unevaluatedProperties", |
karenetheridge
force-pushed
the
ether/unevaluatedProperties_uncles
branch
from
cd99094 to
78feea2
Compare
|
I have removed the redundant tests (two in each file). I've left the test descriptions alone, as "uncle" is used to indicate the distinction from the other "sibling" and "cousin" tests. |
Only annotations from sibling keywords (or children of sibling keywords) should be used by unevaluatedItems, unevaluatedProperties, rather than all annotations collected so far. see https://stackoverflow.com/questions/66936884/deeply-nested-unevaluatedproperties-and-their-expectations
karenetheridge
force-pushed
the
ether/unevaluatedProperties_uncles
branch
from
78feea2 to
ed4cf5f
Compare
jdesrosiers
approved these changes
Apr 7, 2021
|
This all seems to be sorted now, so I'm merging. |
karenetheridge
added a commit
to karenetheridge/JSON-Schema-Modern
that referenced
this pull request
Apr 8, 2021
This prevents annotations collected so far from being improperly used by unevaluatedItems, unevaluatedProperties when only annotations from sibling keywords (or children of sibling keywords) should be used. See https://stackoverflow.com/questions/66936884/deeply-nested-unevaluatedproperties-and-their-expectations and json-schema-org/JSON-Schema-Test-Suite#472
|
Thanks for handling this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only annotations from sibling keywords (or children of sibling keywords)
should be used by unevaluatedItems, unevaluatedProperties, rather than all
annotations collected so far.
see https://stackoverflow.com/questions/66936884/deeply-nested-unevaluatedproperties-and-their-expectations