test that array-items/prefixItems adjusts the starting position for schema-items/additionalItems #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Array https://json-schema.org/draft/2020-12/json-schema-core.html#rfc.section.10.3.1.2
NVM. You use |
jdesrosiers
approved these changes
Apr 13, 2021
jdesrosiers
requested changes
Apr 13, 2021
|
oh damn, yes.. I'll rework to preserve the spirit of the tests. |
|
Also.. I wish we had a CI check that ran the schemas against their respective metaschemas :) |
karenetheridge
force-pushed
the
ether/more-items-tests
branch
from
91c1ba3 to
cd54068
Compare
karenetheridge
changed the title
|
I've fixed the tests to as best match what I was going for as possible, as this scenario isn't clearly tested by the other cases: that additionalItems (or schema-items in 2020-12) does not start with the first item when array-items/prefixItems validated that first item already. |
jdesrosiers
approved these changes
Apr 13, 2021
karenetheridge
changed the title
…chema-items/additionalItems
karenetheridge
force-pushed
the
ether/more-items-tests
branch
from
cd54068 to
4e266c3
Compare
|
rebased one last time for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this gap in the test coverage when implementing prefixItems for 2020-12.