Skip to content

Reconcile terminology in the sanity checker with the README #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

Julian
Copy link
Member

@Julian Julian commented Jun 29, 2022

(A lot of what's here is minor Python modernization, this was written
awhile ago...)

But the main "useful" thing is to reconcile the language in the
implementation here with what's in the README now:

https://github.com/json-schema-org/JSON-Schema-Test-Suite#terminology

i.e.:

files -> files
groups -> cases
cases -> tests

(A lot of what's here is minor Python modernization, this was written
awhile ago...)

But the main "useful" thing is to reconcile the language in the
implementation here with what's in the README now:

https://github.com/json-schema-org/JSON-Schema-Test-Suite#terminology

i.e.:

    files -> files
    groups -> cases
    cases -> tests
@Julian
Copy link
Member Author

Julian commented Jul 5, 2022

Will take the silence as indifferent approval given this isn't very impactful of a change :) but anyone feel free to pipe up with improvements.

@Julian Julian merged commit 9cb7da9 into main Jul 5, 2022
@Julian Julian deleted the sanity-check-terminology branch July 5, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant