Remove instances of $id in content related annotation tests
#775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
|
Else maybe we can remove the |
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 6, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 6, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
jdesrosiers
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Yes, that would be the correct expected property, but ...
Else maybe we can remove the
$id?
Yes, the $id shouldn't be included. I included that originally because I was returning the schema location as the annotation value and the URI of the schema was relevant to that value. But then we decided in a discussion not too long ago that it should be the schema object and not the location. When I changed the test, the $id was no longer necessary and should have been removed. Although both fixes work, I think the best solution is to remove $id. It's not needed.
jviotti
changed the title
$id for annotation schema location assertions$id in content related annotation tests
|
@jdesrosiers Makes sense. Done! I updated the PR to remove the identifiers instead |
Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
annotations-content-id
branch
from
1c331cf to
72c670b
Compare
jdesrosiers
approved these changes
Jun 6, 2025
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 6, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 6, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
|
Is there anything preventing the merge of this PR? |
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 11, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 11, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 11, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 11, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jun 11, 2025
See: json-schema-org/JSON-Schema-Test-Suite#775 Fixes: #442 Signed-off-by: Juan Cruz Viotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to finally incorporate the annotation test suite in Blaze, and this is the one issue I found. Given the schema declares
$id, the assertion should probably assert against the actual full URI?