This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Custom Annotations Will Continue #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
changed the title
Deploying with
|
| Latest commit: |
483baf6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ac70bec.blog-cie.pages.dev |
| Branch Preview URL: | https://gregsdennis-supporting-svas.blog-cie.pages.dev |
jdesrosiers
approved these changes
Apr 5, 2023
|
|
||
| This option defines a new Core keyword such as `$ignored` that would hold an array of the names of keywords to ignore. This would allow schema authors to explicitly define the keywords they wanted to use. | ||
|
|
||
| Like alternative #1, this has the problem that JSON Schema doesn't currently have the mechanisms to perform the kind of meta-schema validation that would be required, as well as the same scoping issues. It's also possible that a schema author could ignore a keyword that would later be added to the spec or some vocabulary, meaning that it _shouldn't_ be ignored, resulting in surprisingly wrong validations. |
There was a problem hiding this comment.
"surprisingly wrong" == "compatibility violation". That might be worth mentioning.
There was a problem hiding this comment.
Thanks. I'll try to work that in.
Relequestual
approved these changes
Apr 6, 2023
|
Well done write up! Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on json-schema-org/json-schema-spec#1394
(I don't think we have the PR dependencies action here. Maybe I should add it at the org level. Can I do that? Does that work?) (It works now 😉🎉)