Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

WIP go at WIP Release Notes #276

Merged
merged 3 commits into from
Aug 14, 2019
Merged

WIP go at WIP Release Notes #276

merged 3 commits into from
Aug 14, 2019

Conversation

philsturgeon
Copy link
Contributor

No description provided.

@Relequestual
Copy link
Member

What's the long term idea behind this page?
Where would it go? How would people find it? Where do you think it should be linked from?

We DO have a changelog in the spec documents, but I accept that a more overall and user friendly version could be useful.

I'm planning a re-working of the json-schema.org home page once draft-8 is out. I think we need to up our game on it.

@handrews
Copy link
Contributor

@Relequestual we always have these.

For draft-06:

For draft-07:

Usually I write them after people complain at me after a new draft, but I will not be available to do so this time.

@philsturgeon thanks for getting this started I'll review as soon as I get a chance.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @philsturgeon , really sorry I lost track of this due to day job upheavals.

I have a couple of comments on things that I think could be points of confusion, otherwise this is a great base to start from.

Can you also add a link from the work-in-progress/index.md file?

[`"definitions"`](json-schema-core.html#rfc.section.TODO) | **removed** | use new "$defs" core keyword
[`"unevaluatedProperties" and "unevaluatedItems"`](json-schema-core.html#rfc.section.TODO) | **added** |
[`"$ref"`](json-schema-core.html#rfc.section.TODO) | **changed** | can now have siblings (keywords next to it)
[`"$defs"`](json-schema-core.html#rfc.section.10.TODO) | **added** | moved over to core from validation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was renamed from dependencies in the move

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you maybe throw some changes on top of this? I'm implementing every bit of feedback I understand but this one is escaping me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philsturgeon because I wrote it wrong! I meant "renamed from definitions", not dependencies 🤦‍♂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philsturgeon I don't understand how people add suggestions as diffs- if there's a button for it I don't see it.

Just change **removed** to **renamed** and 'use new "$defs" keyword` to 'use renamed "$defs" keyword'

But really this is the least significant thing so I might just approve/merge as is and we can tweak this later.

@philsturgeon philsturgeon requested a review from handrews August 14, 2019 10:21
@handrews handrews merged commit d8f6975 into master Aug 14, 2019
@Relequestual Relequestual deleted the release-notes branch October 5, 2020 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants