-
-
Notifications
You must be signed in to change notification settings - Fork 320
Update CONTRIBUTING.md to remove outdated information #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c0382ec
Update CONTRIBUTING.md to remove outdated information
benjagm ee701f2
Update CONTRIBUTING.md
benjagm 64fccb2
Update CONTRIBUTING.md
benjagm 625fc14
Update CONTRIBUTING.md
benjagm debcc2d
Adding suggestion made in the PR.
benjagm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,85 +1,46 @@ | ||
# Guidelines for contributing to the JSON Schema project | ||
|
||
## Issues | ||
## Contributing to JSON Schema Specification | ||
|
||
Issues should identify an problem, enhancement, or use case; and propose some course of action for the draft. For alternate support channels, [see the json-schema.org website](http://json-schema.org/) or the [jsonschema tag on stackoverflow](https://stackoverflow.com/tags/jsonschema). | ||
Thanks for taking the time to contribute! 🎉👍 | ||
|
||
## Milestones | ||
JSON Schema is an evolving language. This repository contains the specification text as well as Pull Requests with suggested improvements and contributions. | ||
|
||
Each milestone is an estimation of the work that will be done for the next draft. Milestones are typically named after the meta-schema draft number, and the *open* milestone with the lowest draft number is the current active project. | ||
Contributions that do not change the interpretation of the spec but instead improve legibility, fix editorial errors, clear up ambiguity and improve examples are encouraged and are often merged by a spec editor with little process. | ||
|
||
Issues may be removed from a milestoned due to lack of consensus, lack of anyone with the correct expertise to make a PR, or simply because we wish to publish a draft and defer the remaining issues to the next draft. | ||
However, contributions that _do_ meaningfully change the interpretation of the spec must follow the Specification Development Process which is ⚠️already under discussion and development⚠️. | ||
|
||
Numbered milestones other than the lowest-numbered one are used to tentatively organize future work, but may be completely reorganized once work on that draft actually begins. | ||
## Issues | ||
|
||
The `draft-future` milestone is for issues for which there is an agreement that they should be addressed, but no specific timeline. | ||
Issues should identify an problem, enhancement, or use case; and propose some course of action for the draft. For alternate support channels, see the [json-schema.org website](http://json-schema.org/) or join our [Slack workspace](https://json-schema.org/slack)**. | ||
benjagm marked this conversation as resolved.
Show resolved
Hide resolved
benjagm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Pull requests | ||
## Pull Requests | ||
|
||
We welcome pull requests, both for editorial suggestions and to resolve open issues. | ||
|
||
If the pull request would solve a particular issue, reference the issue in the pull request description. | ||
|
||
Changes that would affect implementation behavior should typically be opened as an issue first. | ||
|
||
Generally, pull requests should be made to the `main` branch unless it is a | ||
patch update and we are in a patch phase of the | ||
[release process](https://github.com/json-schema-org/community/discussions/7). | ||
In that case there will be a branch named something like `2020-12-patch` that | ||
the PR should target instead. | ||
|
||
Most PRs, including all PRs that impact implementation behavior, will be left open for a minimum of 14 days. Minor wording fixes may be merged more quickly once approved by a project member. | ||
|
||
## Internet-Drafts and meta-schemas | ||
|
||
An Internet-Draft (I-D) publication replaces previous documents in their entirety. | ||
|
||
I-D updates that are purely editorial bug fixes (with no implementation-impacting changes) will continue to use the same meta-schemas as the version that they fix. | ||
|
||
I-D updates that impact behavior, whether as a bug fix or a new, changed, or removed feature, will have new meta-schemas published along with them. | ||
Generally, pull requests should be made to the `main` branch unless it is a patch update and we are in a patch phase. In that case there will be a branch named something like `2020-12-patch` that the PR should target instead. | ||
|
||
The meta-schema URI is used to differentiate between different vocabularies (currently only Validation and Hyper-Schema). | ||
Most PRs, including all PRs that impact implementation behavior, will be left open for a minimum of 14 days. Minor wording fixes may be merged more quickly once approved by a project member. | ||
|
||
The authority on JSON Schema behavior is the respective specification document, not the JSON meta-schema; the JSON version of the meta-schema is maintained in an informative capacity only. | ||
|
||
As an informative document, bugs in the meta-schema may be fixed in place to align them with the normative specification. Examples of in-place fixes include adding an accidentally omitted keyword or fixing an incorrect type. By definition, no correct schema should fail validation against the meta-schema after a bug fix, although previously validating incorrect schemas may start to (correctly) fail validation. | ||
|
||
## Conduct | ||
|
||
All official channels including the mailing list, GitHub organization, Slack server, and IRC channels, follow our [Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). | ||
|
||
|
||
## Financial contributions | ||
|
||
We also welcome financial contributions in full transparency on our [open collective](https://opencollective.com/json-schema). | ||
Anyone can file an expense. If the expense makes sense for the development of the community, it will be "merged" in the ledger of our open collective by the core contributors and the person who filed the expense will be reimbursed. | ||
|
||
## Credits | ||
## Milestones | ||
|
||
### Code Contributors | ||
Each milestone is an estimation of the work that will be done for the next draft. Milestones are typically named after the meta-schema draft number, and the _open_ milestone with the lowest draft number is the current active project. | ||
|
||
This project exists thanks to all the people who contribute. [[Contribute](CONTRIBUTING.md)]. | ||
<a href="https://github.com/json-schema-org/json-schema-spec/graphs/contributors"><img src="https://opencollective.com/json-schema/contributors.svg?width=890&button=false" /></a> | ||
Issues may be removed from a milestoned due to lack of consensus, lack of anyone with the correct expertise to make a PR, or simply because we wish to publish a draft and defer the remaining issues to the next draft. | ||
|
||
### Financial Contributors | ||
Numbered milestones other than the lowest-numbered one are used to tentatively organize future work, but may be completely reorganized once work on that draft actually begins. | ||
|
||
Become a financial contributor and help us sustain our community. [[Contribute](https://opencollective.com/json-schema/contribute)] | ||
The `draft-future` milestone is for issues for which there is an agreement that they should be addressed, but no specific timeline. | ||
|
||
#### Individuals | ||
## Code of Conduct | ||
|
||
<a href="https://opencollective.com/json-schema"><img src="https://opencollective.com/json-schema/individuals.svg?width=890"></a> | ||
All official channels including the mailing list, GitHub organization, Slack server, and IRC channels, follow our [Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). | ||
benjagm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
#### Organizations | ||
## Have Questions? | ||
|
||
Support this project with your organization. Your logo will show up here with a link to your website. [[Contribute](https://opencollective.com/json-schema/contribute)] | ||
You can join the `#specification` channel in our [Slack workspace](https://json-schema.org/slack)** to interact with other community members involved in the Specification development, share new ideas and ask questions. | ||
benjagm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
<a href="https://opencollective.com/json-schema/organization/0/website"><img src="https://opencollective.com/json-schema/organization/0/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/1/website"><img src="https://opencollective.com/json-schema/organization/1/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/2/website"><img src="https://opencollective.com/json-schema/organization/2/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/3/website"><img src="https://opencollective.com/json-schema/organization/3/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/4/website"><img src="https://opencollective.com/json-schema/organization/4/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/5/website"><img src="https://opencollective.com/json-schema/organization/5/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/6/website"><img src="https://opencollective.com/json-schema/organization/6/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/7/website"><img src="https://opencollective.com/json-schema/organization/7/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/8/website"><img src="https://opencollective.com/json-schema/organization/8/avatar.svg"></a> | ||
<a href="https://opencollective.com/json-schema/organization/9/website"><img src="https://opencollective.com/json-schema/organization/9/avatar.svg"></a> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.