Skip to content

Various hyper-schema example fixes #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Conversation

handrews
Copy link
Contributor

What is it about publishing/releasing something that makes
errors jump out of text that you (and others) went over so
many times during final review?

  • "base" URIs need to end in "/" for the "href" values to work,
    although when "base" has no path component it probably works
    either way
  • "-wip" got left in the example meta-schema URIs :-(
  • A cref about "-wip" being a placeholder got left in, although
    not anywhere near the examples where the "-wip" was otherwise
    apparent
  • Tree node example lacked "$id", "$schema", and opening {
  • There was no text in between the collection schema and instance

These are small but potentially quite confusing. I plan to add an errata
list to the web site, but after some time for other obvious errors to be
spotted it might be worth publishing a purely bugfix update as
draft-handrews-json-schema-hyperschema-01 (still with draft-07 meta-schema).

Apparently I did remember to remove all of the "-wip" from the validation spec.

What is it about publishing/releasing something that makes
errors jump out of text that you (and others) went over so
many times during final review?

* "base" URIs need to end in "/" for the "href" values to work,
  although when "base" has no path component it probably works
  either way
* "-wip" got left in the example meta-schema URIs :-(
* A cref about "-wip" being a placeholder got left in, although
  not anywhere near the examples where it at least would have
  made sense
* Tree node example lacked "$id", "$schema", and opening {
* There was no text in between the collection schema and instance
@handrews
Copy link
Contributor Author

I think what I'm going to do is merge PRs like this to both the master and draft-07 branches. Then if we decide that a bugfix draft is needed (meaning no specification changes, only corrections to align with the specification intended to be described by the draft-07 meta-schemas), we can publish that off of the draft-07 branch.

This would not be all that unusual btw. The reason that you don't see a draft-zyp-json-schema-00 on the IETF tracker chart is that it had an error and draft-zyp-json-schema-01 was published later that same day.

@handrews handrews changed the title Various hyper-schema example fixes :-( Various hyper-schema example fixes Nov 25, 2017
@handrews handrews merged commit 1a93be3 into json-schema-org:master Nov 27, 2017
@handrews handrews deleted the errata branch November 27, 2017 05:16
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants