Skip to content

Clarify annotation collection with applicators #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Clarify annotation collection with applicators #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4050ae4
Clarify annotation collection with applicators
handrews Jul 26, 2019
69b313c
Clarify examining for vs collecting annotations
handrews Jul 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions jsonschema-core.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,10 @@
<t>
Evaluation of a parent schema object can complete once all of its
subschemas have been evaluated, although in some circumstances evaluation
may be short-circuited due to assertion results.
may be short-circuited due to assertion results. When annotations are
being collected, some assertion result short-circuiting is not possible
due to the need to examine all subschemas for annotation collection, including
those that cannot further change the assertion result.
</t>
<section title="Keyword Interactions">
<t>
Expand Down Expand Up @@ -1981,6 +1984,9 @@
<t>
An instance validates successfully against this keyword if it validates
successfully against at least one schema defined by this keyword's value.
Note that when annotations are being collected, all subschemas MUST
be examined so that annotations are collected from each subschema
that validates successfully.
</t>
</section>

Expand Down Expand Up @@ -2245,16 +2251,10 @@
</t>
<t>
An array instance is valid against "contains" if at least one of
its elements is valid against the given schema. This keyword
does not produce annotation results.
<cref>
Should it produce a set of the indices for which the
array element is valid against the subschema? "contains"
does not affect "additionalItems" or any other current
or proposed keyword, but the information could be useful,
and implementation that collect annotations need to
apply "contains" to every element anyway.
</cref>
its elements is valid against the given schema. Note that when
collecting annotations, the subschema MUST be applied to every
array element even after the first match has been found. This
is to ensure that all possible annotations are collected.
</t>
</section>
</section>
Expand Down
6 changes: 3 additions & 3 deletions jsonschema-validation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,9 +1220,9 @@
their results, without asserting any conditions of their own.
Without assertion keywords, these applicators can only cause assertion
failures by using the false boolean schema, or by inverting the result
of the true boolean schema. For this reason, they are better defined
as a generic mechanism on which validation, hyper-schema, and extension
vocabularies can all be based
of the true boolean schema (or equivalent schema objects).
For this reason, they are better defined as a generic mechanism on which
validation, hyper-schema, and extension vocabularies can all be based.
</t>
<t hangText='"dependencies"'>
This keyword had two different modes of behavior, which made it
Expand Down