This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Correct some uses of 'URI' to 'URI reference' in structuring #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dealing with an issue in a set of schemas:
https://pagure.io/fedora-ci/messages/issue/67
I got rather confused by these docs until I went and read the
official spec drafts. In several places while discussing
$id
and
$ref
, these docs claim these must be "URIs", but this isnot what the official draft says. It says they must be "URI-
references". From section 8.2, referring to
$id
:"If present, the value for this keyword MUST be a string, and
MUST represent a valid URI-reference [RFC3986]."
From section 8.3, referring to
$ref
:"The value of the "$ref" property MUST be a URI Reference."
This is a crucial and significant difference, as we can see in
RFC3986:
"A URI-reference is either a URI or a relative reference. If
the URI-reference's prefix does not match the syntax of a scheme
followed by its colon separator, then the URI-reference is a
relative reference."
That is, there is no such thing as a "relative URI" (since RFC
3986 came in, anyway, and clarified this as compared to earlier
RFCs). URIs are absolute by definition. If the doc says something
must be a 'URI' then the most obvious reading is that it must be
an absolute-URI as defined in RFC3986. If it can in fact be a
relative reference, we must make this clear.
Signed-off-by: Adam Williamson [email protected]