Fix #93 ($ref to local definition not working) #119
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #110. This pull request is based @stoiev's branch. First, thanks for his great work!
(I skipped fc947a6 commit. Because it is not related with this problem and it contains some problems; composer.lock should not be ignored (see http://blog.naderman.de/2014/02/17/replace-conflict-forks-explained/) and netbeans project directories should be ignored in $HOME/.gitignore)
And I've referenced some implementation of brandur/json_schema (it is Ruby JSON Schema validation library). I really appreciate to the library.
My fix resolves some problems of #110; e.g. the #110 implementation only resolves the top level of $ref but my implementation resolves any level of a path.
But, however, it doesn't pass json/tests/draft4/ref.json yet. We should effort resolve this problem too, but the inline dereferencing problem is needed to fix ASAP.