Skip to content

[Proposal] new constraints name - for PHP7 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2015

Conversation

lsv
Copy link
Contributor

@lsv lsv commented Mar 19, 2015

All constraints objects are now suffixed with *Constraint so we aint running into reserved words.
Suffixed Constraint to all contraints and not just "String"

Will fix #128

@Danack
Copy link

Danack commented Mar 20, 2015

+1

Scalar type hints are now merged into master for 7, and so this needs to be pulled, and tagged so that PHP projects can continue to use Composer on 7.

@rdlowrey
Copy link

👍

1 similar comment
@Rican7
Copy link

Rican7 commented Mar 23, 2015

👍

@ghost
Copy link

ghost commented Mar 23, 2015

👍 x 💯

@bighappyface
Copy link
Collaborator

How do we go about making progress on this? @justinrainbow hasn't made a commit since 8/24/2014 and there are several PRs open to improve this code dramatically. Simply put, I need this package to progress.

I propose we create a new group, fork this repo over to it, and add the new repo/package to packagist for easy composer swap.

Thoughts on how to move this package forward?

@salathe
Copy link

salathe commented Mar 23, 2015

👍

Re: forking... I would give @justinrainbow time to do something here, being the (current) canonical repo.

justinrainbow added a commit that referenced this pull request Mar 23, 2015
[Proposal] new constraints name - for PHP7
@justinrainbow justinrainbow merged commit 680d026 into jsonrainbow:master Mar 23, 2015
@justinrainbow
Copy link
Collaborator

Hey guys, sorry for the slow response. I'm going to merge this PR now for a release, then go through some of the other PR's with tests later today.

As @bighappyface mentioned, I'm not actively working on this project and rarely have time to go through the many PRs. If anyone is interested in becoming a collaborator, send me a message. Or if there is another group that would like to take over ownership I'd be happy to transfer it. Since this project is important for Composer - maybe they would like to take it over? /cc @Seldaek

@justinrainbow
Copy link
Collaborator

Version v1.4.0 has now been released

@bighappyface
Copy link
Collaborator

@justinrainbow I'll collaborate (sorry, no private messages anymore)

@rdlowrey
Copy link

Hey thanks, @justinrainbow. I'm sure folks understand what a PITA it can be to merge PRs on a project that's on your personal back-burner. No worries and thanks for taking care of it :)

@Seldaek
Copy link
Contributor

Seldaek commented Mar 24, 2015

@justinrainbow kinda have enough on my plate but I think the json-schema spec is fairly stable (dead?) so shouldn't be too often that you need to maintain things on this front :)

@lsv lsv deleted the php7-reserved-names branch March 24, 2015 10:27
@philsturgeon
Copy link

@justinrainbow Hey, just here to drop an idea out there. The PHP League has a few times before taken on packages that others did not have time for. It's not so much a dumping ground, but more of a way to stale code.

It can also be handy for reducing bus factor, so if the project lead is AWOL or gets flattened then we always have other members to look after things.

I asked around on the League mailing list and @shadowhand has offered to pick this up, as he uses it actively.

Does this sound like a plan?

@philsturgeon
Copy link

And by plan I mean: we can transfer it to our org, or fork it and Composer can use the fork.

I'd rather go with transfer though as that sorts out any confusion over which version to use and keeps stars/prs/etc.

@keradus
Copy link
Contributor

keradus commented Mar 24, 2015

It is cool to have this merged, but...
This changed public interface (class names), which is a BC break, therefore the release should be new MAJOR, not MINOR...

@onlinesid
Copy link
Contributor

I've just started using this library but plan to use it on more projects. I'd be interested to become one of the collaborators.

hakre pushed a commit to hakre/json-schema that referenced this pull request Mar 26, 2015
[Proposal] new constraints name - for PHP7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String will likely become a reserved word in PHP 7