Enhancement: Switch to PSR-4 autoloading #169
Conversation
👎 |
|
@localheinz @GrahamCampbell I am concerned about this PR as well. While I am all for PSR-4, flattening the directories could be really problematic for forked variations with patches applied in lieu of the historically slow turnaround for PR merges on this repo. IMO, PSR-4 is not out, but we will need to spend more time on the structural impacts. |
localheinz
force-pushed
the
feature/psr-4
branch
from
1aba9e8 to
d41b238
Compare
|
Rebased and push-forced, so switching to PSR-4 now, but not flattening the directory structure! |
| @@ -44,10 +44,10 @@ | |||
| "phpdocumentor/phpdocumentor": "~2" | |||
| }, | |||
| "autoload": { | |||
| "psr-0": { "JsonSchema": "src/" } | |||
| "psr-4": { "JsonSchema\\": "src/JsonSchema" } | |||
There was a problem hiding this comment.
Should end in a / for the dirnames in both cases.
localheinz
force-pushed
the
feature/psr-4
branch
from
d41b238 to
344315f
Compare
|
+1 @GrahamCampbell you good with this? |
|
👍 |
|
Derp! Just saw @GrahamCampbell responded on this and rolled v1.4.4 😞 Will merge and account for this in 1.4.5 once another source code-related change is merged. |
Enhancement: Switch to PSR-4 autoloading
This PR
Follows #164.