Skip to content

Fix: Consistently create error messages #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix: Consistently create error messages #172

wants to merge 2 commits into from

Conversation

localheinz
Copy link
Contributor

This PR

  • consistently uses sprintf() for creating error messages
  • consistently uses single quotes instead of double quotes for error messages

Follows #170 (comment).

@bighappyface
Copy link
Collaborator

This one will be tricky. There are others messing with the error messaging:

#122
#142

While I am fine with sprintf I know others are not, and performance impacts are debatable in context of micro-optimization.

I think we need a few people in favor of this one to force the change in convention.

@GrahamCampbell @alecsammon @Maks3w @samkeen thoughts?

@localheinz
Copy link
Contributor Author

@bighappyface

I'm happy to push #122 and #142 forward first!

@doits @onlinesid

What do you think, can you rebase your PRs?

@onlinesid
Copy link
Contributor

@localheinz I have rebased my #142

@bighappyface
Copy link
Collaborator

Closing for now

@localheinz localheinz deleted the fix/consistently-sprintf branch April 14, 2016 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @bighappyface @onlinesid