add oneOf object type tests – one of them fails #187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resolution of the definitions of the objects for the oneOf with $ref referencing something works, but the actual validation of the objects then fails for the second added test case with "prop2 – failed to match exactly one schema".
|
Closed with #182 Please re-open if necessary. |
|
Unfortunately testing will have to wait a month or two. Thanks for the work though! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolution of the definitions of the objects for the
oneOfconstraint with$refreferencing something works, but the actual validation of the objects then fails for the second added test case withprop2 – failed to match exactly one schema.See https://gist.github.com/graste/968573d9c29280b66a7c as well for a small usecase/example.
DON'T JUST MERGE this PR as it contains a failing test case deliberately.