Fixes min/max properties validation for non objects #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
I needed some time to get familiar with #215 and all the PRs that were tried there. So, this fixes both #260 and original #215. Verified. @bighappyface go ahead with merge. We should probably release |
|
+1 Go ahead. |
|
@bighappyface any ETA on releasing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a few tests that covers the problem described in #260.
Also I went the way that previous implementation was done with single
if (is_object($property)).Please have a look at https://github.com/bighappyface/json-schema/blob/1.6.1/src/JsonSchema/Constraints/UndefinedConstraint.php#L169-L186 for reference.
Fixes #260
/cc @mirfilip @bighappyface