Bump json-schema/JSON-Schema-Test-Suite to 1.1.2 #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mirfilip please use a global ignore for the Otherwise +1 |
|
@bighappyface I cannot use a global ignore as some projects I work with do keep this under version control. Anyway, it was rather a thing for every other contributor that uses Jetbrains stuff so that the IDE config doesn't get committed. I can always create an explicit repo exclude, so no problem. I've checked some popular repos and they indeed refrain from specifying IDE specific stuff. Reverting that then. |
|
@mirfilip thanks for the update. Last request: please squash this down. |
mirfilip
force-pushed
the
feature/upgrade-json-schema-test-suite-to-1.1.2
branch
from
58bacc0 to
a4d0b4c
Compare
|
@bighappyface Sure! Also, please see #265 as it supersedes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @bighappyface
No effort move, all tests still passing. I'm currently looking at using
1.2.0(seen that)