Skip to content

Enhancement: Add .editorconfig #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 30, 2017

This PR

  • adds an .editorconfig

πŸ’β€β™‚οΈ For reference, see http://editorconfig.org.

trim_trailing_whitespace = false

[*.yml]
indent_size = 2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this configuration reflects what is mostly used within this project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these settings may reflect current usage, they aren't necessarily desirable, and we should probably have a discussion around indentation particularly.

I'd rather like to see the entire project move to a 4-space indent, unless anyone else objects. What we have now is largely historical, and comes from a very old codebase with none of the original maintaners remaining.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, @erayd!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@localheinz shall we move to 4 space indention and move this forward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bighappyface

Can do! Been busy today with tax preparation. Taking a look tomorrow!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bighappyface

Updated the indentation! πŸ‘

@localheinz localheinz force-pushed the feature/editorconfig branch 2 times, most recently from f5e9fc2 to 3a60c09 Compare October 24, 2018 14:37
@localheinz localheinz force-pushed the feature/editorconfig branch from 44850ce to 6651e1b Compare June 18, 2019 05:50
@localheinz localheinz force-pushed the feature/editorconfig branch from 6651e1b to f19a261 Compare June 18, 2019 05:51
@localheinz localheinz closed this Jan 24, 2021
@localheinz localheinz deleted the feature/editorconfig branch January 24, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants